Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store literal expression type in the AST #90

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented Oct 23, 2022

This is in anticipation of type aliases (#62).

The motivating example is:

type alias WholeNumber = Int;

five : WholeNumber = 5;

Currently we would drop the alias type annotation as part of type checking, but we want to keep it around for more helpful type errors.

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #90 (ed14bc9) into main (0477330) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   78.37%   78.48%   +0.11%     
==========================================
  Files         118      118              
  Lines        8074     8134      +60     
==========================================
+ Hits         6328     6384      +56     
- Misses       1746     1750       +4     
Impacted Files Coverage Δ
crates/ditto-ast/src/expression.rs 78.94% <100.00%> (-7.26%) ⬇️
crates/ditto-checker/src/typechecker/mod.rs 96.77% <100.00%> (+0.34%) ⬆️
...ates/ditto-checker/src/typechecker/substitution.rs 97.97% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmackie jmackie merged commit 6a2aa48 into main Oct 24, 2022
@jmackie jmackie deleted the store-literal-type-information branch October 24, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant