Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert_module_ok! with trycmd tests 🧑‍💻 #91

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented Oct 29, 2022

Added assert-rs/trycmd in #87 and I'm a fan. Seems like a nice way of handling acceptance tests, particularly for a compiler project like this.

I don't really like the assert_module_ok! and assert_module_err! testing macros, and I think https://github.com/assert-rs/trycmd could do better. Hence this PR replaces the former with the latter 👌.

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #91 (0fcf40b) into main (ee223c0) will decrease coverage by 2.76%.
The diff coverage is 4.76%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   78.48%   75.71%   -2.77%     
==========================================
  Files         118      111       -7     
  Lines        8132     7998     -134     
==========================================
- Hits         6382     6056     -326     
- Misses       1750     1942     +192     
Impacted Files Coverage Δ
crates/ditto-ast/src/module.rs 100.00% <ø> (ø)
crates/ditto-checker/src/module/exports/mod.rs 100.00% <ø> (ø)
...ecker/src/module/foreign_value_declarations/mod.rs 100.00% <ø> (ø)
crates/ditto-checker/src/module/imports/mod.rs 90.51% <ø> (ø)
crates/ditto-checker/src/module/mod.rs 100.00% <ø> (ø)
...cker/src/module/type_declarations/tests/acyclic.rs 100.00% <ø> (ø)
...ker/src/module/type_declarations/tests/toposort.rs 100.00% <ø> (ø)
...ker/src/module/value_declarations/tests/acyclic.rs 100.00% <ø> (ø)
...er/src/module/value_declarations/tests/toposort.rs 100.00% <ø> (ø)
...es/ditto-checker/src/typechecker/coverage/tests.rs 100.00% <ø> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmackie jmackie merged commit 7a3303e into main Oct 30, 2022
@jmackie jmackie deleted the checker-trycmd-tests branch October 30, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant