Fix up some attribute errors #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make the style attributes work by translating style strings to a style object. * Make a map of attributes that are not name the same in dom vs react, and always look up the correct attribute. * Trim the text nodes before inserting, as react may not allow whitespace as text nodes for certain kinds of nodes (like colspan in a table - very odd...).
HerrZatacke
reviewed
Aug 27, 2018
HerrZatacke
reviewed
Aug 27, 2018
HerrZatacke
added a commit
that referenced
this pull request
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to cherry pick only changes you want!
I found these changes are required in order to add dom containing styled SVG's (for my specific usecase).
Also, i attribute all copyright to the owner of this repository.