Undo comment change in old schema, document in new #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
This sort of problem would be ruled out by addressing #1252.
branlwyd
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1253 made a change to a comment in
db/20230405185602_initial-schema.up.sql. Generally speaking, we should avoid this, since it affects the checksum, and sqlx would refuse to apply further migrations if it saw such a discrepancy. This PR undoes that change, and documents the new meaning ofreport_aggregations.prep_msgin the newly added migration instead. We could also not take this PR, and make additional manual database modifications to the staging and load test environments. Separately, we may want to start some living documentation of our schema in the docs directory, to codify an explanation of the current state of our schema, instead of relying on comments in many migration scripts.