Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2c std ownedfd #410

Closed
wants to merge 2 commits into from
Closed

2c std ownedfd #410

wants to merge 2 commits into from

Conversation

diwic
Copy link
Owner

@diwic diwic commented Dec 30, 2022

Remove our own OwnedFd since std has one now. Backwards incompatible change, and bumps rust version requirement to 1.63.

@diwic
Copy link
Owner Author

diwic commented Dec 30, 2022

@ids1024 Hi, so was considering taking the plunge and replace our OwnedFd with std's. Here's what it would look like. Not sure why the (normal) CI fails though, do you have any idea? The rustc version should be new enough: https://github.com/actions/runner-images/blob/ubuntu22/20221212.1/images/linux/Ubuntu2204-Readme.md

    --> dbus/src/arg/basic_impl.rs:230:18
    |
230 |     use std::os::fd::OwnedFd;
    |                  ^^ private module

@diwic diwic marked this pull request as draft December 30, 2022 09:21
@ids1024
Copy link
Contributor

ids1024 commented Dec 30, 2022

You should import it from std::os::unix::io rather than std::os::fd. It's in std::os::fd now since it's available on WASI as well as Unix, but that change was done in a later Rust release than the one that added OwnedFd.

@diwic
Copy link
Owner Author

diwic commented Jan 6, 2023

Replaced by #418

@diwic diwic closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants