Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio_server_cr.rs #485

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Update tokio_server_cr.rs #485

merged 1 commit into from
Oct 5, 2024

Conversation

stephin-thomas
Copy link
Contributor

remove duplicate variable declaration and moving the original declaration to right position. My previous change was to add a connection variable creation on top, I could see that it was indeed declared but at the wrong position so removing my previous change and adding the declaration to the right position.

remove duplicate variable declaration and moving the original declaration to right position.
@diwic
Copy link
Owner

diwic commented Oct 1, 2024

I moved it down in d6f5305 to avoid a race condition, are you moving it back up again?

@stephin-thomas
Copy link
Contributor Author

I am not that good with rust, some things go above my head. In my first pull request I added this line because I didn't know the variables where created below then when I became aware of that, to avoid the duplicate creation I moved the original declaration up to where it should be. I also noticed that when running my previous pull request modification I was not getting the reply from the server now that is solved.

@diwic diwic merged commit 8f1fcbb into diwic:master Oct 5, 2024
8 checks passed
@diwic
Copy link
Owner

diwic commented Oct 5, 2024

I think this one's okay, IIRC, the critical thing is not requesting the name before setting up the receiving of incoming messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants