Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode text needs higher contrast #1943

Closed
tim-schilling opened this issue Jul 4, 2024 · 6 comments · Fixed by #1987
Closed

Dark mode text needs higher contrast #1943

tim-schilling opened this issue Jul 4, 2024 · 6 comments · Fixed by #1987

Comments

@tim-schilling
Copy link
Member

The table, non-highlighted, text needs greater contrast with the background in dark mode:

It's currently at 1.73 according to https://coolors.co/contrast-checker/acc8e5-ffffff

Screenshot 2024-07-04 at 11 24 22 AM
@myou1985
Copy link
Contributor

In a Windows11 environment, this was reproduced when the OS mode was "Light" and the app mode was "Dark".
Contrast is important, but wouldn't it be better for the app's style to follow the OS mode?

OS mode:Lignt , App mode:Lignt:
OSLight-AppLight

OS mode:Light , App mode:Dark:
OSLight-AppDark

OS mode:Dark , App mode:Light:
OSDark-AppLight

OS mode:Dark , App mode:Dark:
OSDark-AppDark

@myou1985
Copy link
Contributor

I hope that the information at the following URL will be helpful regarding contrast.
https://w3c.github.io/wcag/techniques/general/G18

@tokibito
Copy link

tokibito commented Aug 7, 2024

@tim-schilling
I'd be grateful for your feedback on @myou1985's comment. I helped him with his investigation.

@tim-schilling
Copy link
Member Author

tim-schilling commented Aug 7, 2024

@tokibito @myou1985 thank you for bringing up reflecting the OS mode. That'd be a reasonable default.

Do either of you have the availability to make these changes? I'd love to see these changes included in the toolbar.

@myou1985
Copy link
Contributor

myou1985 commented Aug 8, 2024

@tim-schilling
Thank you for your response. I will find some time to address this issue on my end.

@myou1985
Copy link
Contributor

@tim-schilling
I have submitted my first pull request to this project,
and I would really appreciate it if you could take a look when you have the time.

This is my first contribution to an open-source project,
so any feedback or suggestions for improvement would be incredibly valuable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants