Dark mode text needs higher contrast #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #1943 by improving the table contrast when the OS mode is set to Light, and the App mode is set to Dark.
Changes Made:
Modified a single line in toolbar.css. This was necessary to address a missing definition when compared with the Light mode settings.
I've attached screenshots for verification of the fix.
OS mode: Light
App mode: Dark
OS mode: Light
App mode: Light
OS mode: Light
App mode: Default
OS mode: Dark
App mode: Dark
OS mode: Dark
App mode: Light
OS mode: Dark
App mode: Default
Fixes #1943
Checklist:
docs/changes.rst.