Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify code coverage as a static value. #1558

Merged
merged 4 commits into from
Dec 23, 2021

Conversation

matthiask
Copy link
Member

No description provided.

@matthiask matthiask changed the title Static coverage percentage Specify code coverage as a static value. Dec 20, 2021
@matthiask
Copy link
Member Author

@tim-schilling I added your suggestion here as a separate pull request, we can continue the discussion here.

cc @pauloxnet

@pauloxnet
Copy link
Member

@matthiask can you resolve conflicts ?

@pauloxnet
Copy link
Member

@matthiask the PR is ready to merge. I see it's still in draft. There's a reason or you can simply remove the draft tag ?

@matthiask
Copy link
Member Author

@matthiask the PR is ready to merge. I see it's still in draft. There's a reason or you can simply remove the draft tag ?

I opened it as a draft because I wasn't sure whether it is a good idea to hardcode the coverage percentage. I'm marking it as ready for review now because I'm basically neutral, not opposed to this.

@matthiask matthiask marked this pull request as ready for review December 23, 2021 15:23
@tim-schilling
Copy link
Member

@matthiask what do you think about that gist revision approach? I'd prefer not to set it statically, but I will if it means the alternative is not having it.

@matthiask
Copy link
Member Author

@matthiask what do you think about that gist revision approach? I'd prefer not to set it statically, but I will if it means the alternative is not having it.

This looks interesting! I suspect that we'd need Jannis' help for this because we don't have access to the repository settings?

I'd merge this pull request and open an issue to re-investigate later if there's a better solution, maybe directly offered by GitHub or someone.

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment indicating to change the readme's coverage badge link in case we don't replace this in the future.

@matthiask matthiask merged commit f03cd64 into django-commons:main Dec 23, 2021
@matthiask matthiask deleted the static-coverage-percentage branch December 23, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants