The path may not always be a true path for stacktraces. #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occassionally we will get a stacktrace that's an importlib instance string representation. While we may be able to put the python path or something else it's likely easier (and more logical) to simply pass that onto the user. I was unable to reproduce the issue in our tests, so I've mocked the case in test_importlib_path_issue_1612. Fixes #1612
matthiask
approved these changes
May 2, 2022
Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
I didn't have time to investigate that part yet. It's likely failing on main as well since the other recent PR has the same failure exception. |
|
You're right. Let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occassionally we will get a stacktrace that's an importlib instance string
representation. While we may be able to put the python path or something else
it's likely easier (and more logical) to simply pass that onto the user.
I was unable to reproduce the issue in our tests, so I've mocked the case
in test_importlib_path_issue_1612.
Fixes #1612