-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1621: Do not crash when encountering unexpected data in the request #1624
Conversation
debug_toolbar/utils.py
Outdated
else: | ||
return [(k, variable.getlist(k)) for k in sorted(variable)] | ||
except TypeError: | ||
return [(f"<{source}>", variable)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the wrapping call already has this associated with the attribute on the request (get, post, files), I don't think we need to use the source. I think using an empty string or something constant will be more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a good point. I have pushed an update but I haven't tested the update (yet)
252f96a
to
a84302c
Compare
@FinnGu I'd appreciate your input and/or testing if you have a way to do this. |
Alright, setting up some tests on my end. And thank you for your quick PR! |
@matthiask I just recently started using the DDT, so I don't know about all of its features. But for my use case, everything works flawlessly! I am now able to raise |
Thanks! Good to hear. |
No description provided.