Check if djdt-store-id is in all headers before usage. #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromium throws an uncatchable warning when a header that can't be accessed is used. While it's not problematic, it's worrisome to developers. This avoids that by first checking that it exists. Fixes #1647
Includes some tests to validate the HistoryPanel.get_headers method.
|
LGTM, let's merge this despite the test failures (which are unrelated and have been happening for some time -- something changed re. selenium, I didn't take the time yet to investigate) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium throws an uncatchable warning when a header that
can't be accessed is used. While it's not problematic, it's
worrisome to developers. This avoids that by first checking
that it exists.
Fixes #1647