Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added functionality to keep unsort the session dict #1673

Merged
merged 5 commits into from
Sep 25, 2022
Merged

added functionality to keep unsort the session dict #1673

merged 5 commits into from
Sep 25, 2022

Conversation

ritiksoni00
Copy link
Contributor

matthiask
matthiask reviewed Sep 18, 2022
View reviewed changes
Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think you're only verifying the failing case though, maybe add a second test where the session contains only string keys (which can actually be sorted)?

tests/panels/test_request.py Show resolved Hide resolved
@tim-schilling tim-schilling mentioned this pull request Sep 20, 2022
Merged
tim-schilling
tim-schilling requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a PR! Please add a mention of this change in docs/changes.rst. That helps reduce effort in releasing new versions.

@tim-schilling tim-schilling merged commit 348e582 into django-commons:main Sep 25, 2022
@tim-schilling
Copy link
Member

Thank you for the work on this @ritiksoni00!

@tim-schilling tim-schilling mentioned this pull request Sep 25, 2022
Closed
@ritiksoni00
Copy link
Contributor Author

Thank you for opening a PR! Please add a mention of this change in docs/changes.rst. That helps reduce effort in releasing new versions.

sorry, tim for not responding.. !

@tim-schilling
Copy link
Member

No worries, thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiask matthiask matthiask left review comments

@tim-schilling tim-schilling tim-schilling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ritiksoni00 @tim-schilling @matthiask