D9pouces wsgi.multiprocess 1 #1765
Conversation
|
Thank you for the PR. I agree that this change is straightforward and a +1 from me. Could you please add a test for this, add a line to the changelog and include a description of how this error occurs within Django Channels? All of that will help the toolbar be easier to maintain and more robust moving forward. |
|
@d9pouces could you provide us with the use case that causes this bug? |
|
@matthiask I think |
|
@tim-schilling I checked, PEP-3333 specifies that You're saying that the better fallback, for example when running under ASGI, would be to render panels right away? I think I'm in agreement. |
|
Yes, that's what I'm saying. A person can still find a way to get this to work via the I'll push my changes to this branch over lunch today. The other change is including a comment and some tests for this particular method. |
If you apply Django middlewares on a HttpRequest without "wsgi.multiprocess" in META, an exception is raised by DJT. This simple patch avoids this bug.
The likely cause of this is that the application is using ASGI since wsgi.multiprocess is a required key for a WSGI application. Since the toolbar currently doesn't support async applications, it's pretty likely that it won't work for this request. If you're a developer reading this and you think I'm wrong, you can set the RENDER_PANELS setting to forcibly control this setting.
Description
If you apply Django middlewares on a HttpRequest without "wsgi.multiprocess" in META, an exception is raised by DJT.
This simple patch avoids this bug.
Fixes # (issue)
Checklist:
docs/changes.rst.