Fix overriding font-family for both light and dark themes #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
fix/override-font-styles
branch
from
79fb0a0 to
636b93e
Compare
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs mention that the toolbar can be customized by overriding the --djdt-* variables defined in :root, like this:
But with the implementation of dark theme support these same variables are also defined in #djDebug[data-theme="light"] with a higher specificity, so in reality you will need to match the specificity of that rule to override the variables.
This moves the font-family declarations to root so changes to the font-family on :root apply to both light and dark themes.