Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rem units from svg #1942

Merged

Conversation

michjnich
Copy link
Contributor

Description

Removes the "1rem" height and width from the svg attributes for the dark/light icons and puts it into css height and width attributes instead

Fixes #1935

Checklist:

  • I have added the relevant tests for this change. (Note: No tests added)
  • I have added an item to the Pending section of docs/changes.rst.

@michjnich
Copy link
Contributor Author

Quick note: I couldn't run full tests here without setting up a load of databases locally (side note, might be an idea to include a compose file that sets up the various dbs for the full tox run, to make life simpler), and since this was a pure display change I figured that was probably OK :)

@tim-schilling
Copy link
Member

Looks good! I'll pull this down, verify it's right then merge.

We don't expect people to run the tests locally against all DBs unless that's what the change is relevant for. Testing against sqlite is sufficient.

@tim-schilling tim-schilling merged commit eff9128 into django-commons:main Jul 4, 2024
23 checks passed
@tim-schilling
Copy link
Member

Thank you @michjnich!

@michjnich
Copy link
Contributor Author

And thank you for a pleasant contributor experience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG definitions have width in rem which throws console errors
2 participants