Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added more explanations to the example/readme file. #2027

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

jong-seoung
Copy link
Contributor

Description

Since the installation instructions in the example/readme were insufficient, I modified it to use requirements.txt for installation instead of directly using Django.

Fixes #1949

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

example/README.rst Outdated Show resolved Hide resolved
Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally in favor of this change. My suggestion is a minor grammatical change.

Co-authored-by: Tim Schilling <schilling711@gmail.com>
@matthiask matthiask merged commit 7f18cf5 into django-commons:main Nov 5, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jinja2 dependency breaks default install
3 participants