Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Github workflow #85

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve Github workflow #85

wants to merge 7 commits into from

Conversation

denys-chura
Copy link
Collaborator

@denys-chura denys-chura commented Oct 7, 2024

After 60 days of inactivity workflows with schedule trigger will be disabled by Github https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule. As it turns out, this workflow also will not be triggered by pull_request /push triggers which is not ideal. We can mitigate that by creating re-usable workflow and call it from two different workflows on triggered on schedule and another one triggered on pull_request /push.

Change list

  • Update pull_request triggers types to only ones which correspond to code changes;
  • Extract jobs from default.yml workflow to re-usable test.yml to be able to split default workflow to two workflow with different set of triggers - "schedule" and "pull_request/push"

Do not delete this PR branch untill #86 is merged to main

- Update `pull_request` triggers types to only ones which correspond to code changes;
- Extract jobs from `default.yml` workflow to re-usable `test.yml` to be able to split default workflow to two workflow with different set of triggers - "schedule" and "pull_request/push"
Copy link
Collaborator

@bulya bulya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bulya
Copy link
Collaborator

bulya commented Oct 15, 2024

In the context of this PR, we can also add a feature to cancel the currently running job or workflow in the same concurrency group. https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#concurrency
In the same way, as we want to add to the generated project's workflow - https://github.com/django-stars/backend-skeleton/pull/89/files#diff-6b6e5067e5f2be7f76884a405b3180738fad9fc44f11f63fbb019641426e03feR4-R6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants