[DI-2708] Ruff ALL rules #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO All these type annotations litter code a lot, especially things like:
What do you think about using an if statement with TYPE_CHECKING? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff ALL rules
Note
More info in the internal Slack thread https://djangostars.slack.com/archives/C04E2PGC8AZ/p1728395130523569
The main change is
select = ["ALL"]asruffrules, with some minimal exceptions.Adds a lot of type annotations that would be helpful for further
mypyintegration.Also, running
make api-checkfor checking linting and formatting of the generated default project.