Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically convert esmodules to commonjs #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automatically convert esmodules to commonjs #182

wants to merge 1 commit into from

Conversation

djblue
Copy link
Owner

@djblue djblue commented Jun 9, 2023

No description provided.

@@ -41,6 +43,9 @@
cache
modules))))

(defn- ->common-js [source]
(.-code (babel/transformSync source #js {:plugins #js [commonjs]})))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to find a way to skip when not needed as this introduces a lot of overhead

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you do it only when the package.json specifies "type": "module"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants