Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MSRV to 1.58 for now #134

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Set MSRV to 1.58 for now #134

merged 1 commit into from
Aug 3, 2022

Conversation

djc
Copy link
Owner

@djc djc commented Aug 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #134 (d965f10) into main (92306cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files           7        7           
  Lines         689      689           
=======================================
  Hits          544      544           
  Misses        145      145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92306cb...d965f10. Read the comment docs.

@djc
Copy link
Owner Author

djc commented Aug 1, 2022

@nyurik do you know what might be going on with the CI failure here?

@nyurik
Copy link
Contributor

nyurik commented Aug 3, 2022

@djc the MSRV must be set to 1.58, not 1.56. That's the first version with inline format strings. See #125 (comment)

@djc djc changed the title Set MSRV to 1.56 for now Set MSRV to 1.58 for now Aug 3, 2022
@djc djc merged commit c1855b1 into main Aug 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the msrv branch August 3, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants