Add option to retry connection creation, on by default #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #102
Overall I agree with the point that connection retries are good and transient errors are common. However, sometimes the application knows better. E.g. we use bb8 in https://github.com/levkk/pgcat and during database restarts, we don't want bb8 to retry because we know the database is down (just for a few seconds), and we have logic to handle and back-off in our code. In our situation, we have thousands of clients creating a thundering herd of retries.
This PR makes the retries optional, enabled by default to preserve existing behavior.