Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration of queue strategy #165

Merged

Conversation

zainkabani
Copy link
Contributor

@zainkabani zainkabani commented May 30, 2023

Pervious implementation of this feature was incorrect, this PR fixes it.

@zainkabani zainkabani marked this pull request as ready for review May 30, 2023 20:52
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.04 🎉

Comparison is base (ad653e0) 72.07% compared to head (0e71b0a) 72.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   72.07%   72.12%   +0.04%     
==========================================
  Files           6        6              
  Lines         598      599       +1     
==========================================
+ Hits          431      432       +1     
  Misses        167      167              
Impacted Files Coverage Δ
bb8/src/api.rs 63.79% <0.00%> (ø)
bb8/src/internals.rs 92.76% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djc djc merged commit 5e5ce3d into djc:main May 31, 2023
@djc
Copy link
Owner

djc commented May 31, 2023

I just published bb8 0.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants