Track PooledConnection state explicitly #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 72.47% 72.51% +0.04%
==========================================
Files 6 6
Lines 534 553 +19
==========================================
+ Hits 387 401 +14
- Misses 147 152 +5 ☔ View full report in Codecov by Sentry. |
0dca340 caused a regression where the library would update the pool state to mark a connection as lost because we disconnected the underlying connection from the `PooledConnection`. Instead, add a `state` field to `PooledConnection` that tracks the state of the `conn` field, so we can do the right thing on drop.
|
Merged and published this proactively to make this easy to consume and since I'm pretty sure it addresses a regression from 0.8.2. Still happy to address any feedback anyone might have! |
nicolasvan
added a commit
to OneSignal/pgcat
that referenced
this pull request
Mar 12, 2024
To get djc/bb8#186 and djc/bb8#189
nicolasvan
added a commit
to OneSignal/pgcat
that referenced
this pull request
Mar 18, 2024
To get djc/bb8#186 and djc/bb8#189 which fix potential deadlocks (djc/bb8#154)
magec
pushed a commit
to OneSignal/pgcat
that referenced
this pull request
Oct 23, 2024
To get djc/bb8#186 and djc/bb8#189 which fix potential deadlocks (djc/bb8#154)
magec
pushed a commit
to OneSignal/pgcat
that referenced
this pull request
Oct 23, 2024
To get djc/bb8#186 and djc/bb8#189 which fix potential deadlocks (djc/bb8#154). Also, this (djc/bb8#225) was needed to prevent a connection leak which was conveniently spotted in our integration tests.
drdrsh
pushed a commit
to postgresml/pgcat
that referenced
this pull request
Oct 28, 2024
* Update bb8 to 0.8.6 To get djc/bb8#186 and djc/bb8#189 which fix potential deadlocks (djc/bb8#154). Also, this (djc/bb8#225) was needed to prevent a connection leak which was conveniently spotted in our integration tests. * Ignore ./.bundle (created by dev console) --------- Co-authored-by: Jose Fernandez (magec) <joseferper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.