Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal improvements (builds on #77) #78

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Internal improvements (builds on #77) #78

wants to merge 7 commits into from

Commits on Aug 18, 2023

  1. Supporting service account key format OR user credential formats 

    This PR supports parsing both formats in either the `GOOGLE_APPLICATION_CREDENTIALS` env variable or the `~/.config/gcloud/application_default_credentials.json` file.
    @msdrigg
    msdrigg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    925dbba View commit details
    Browse the repository at this point in the history

  2. Adding service account impersonation (waiting on djc#76) 

    This PR adds a new `ServiceAccount` format that takes credentials from `source_credentials: ServiceAccount` and then makes a request to get a service account token using those credentials.

This also adds the ability to parse the token format created by `gcloud auth application-default login --impersonate-service-account <service account>`
    @msdrigg
    msdrigg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    baa65d3 View commit details
    Browse the repository at this point in the history

  3. No longer require token_uri in CustomServiceAccount 

    This parameter should be optional and fall back to the default of "https://oauth2.googleapis.com/token".

This is demonstrated here:
https://github.com/golang/oauth2/blob/a835fc4358f6852f50c4c5c33fddcd1adade5b0a/google/google.go#L152
    @msdrigg
    msdrigg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    8063616 View commit details
    Browse the repository at this point in the history

  4. Allowing UserCredentials to support an optional token_uri parameter 

    This comes from go source here:
 https://github.com/golang/oauth2/blob/a835fc4358f6852f50c4c5c33fddcd1adade5b0a/google/google.go#L181C22-L181C22
    @msdrigg
    msdrigg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    71542d1 View commit details
    Browse the repository at this point in the history

  5. Supporting optional audience on ApplicationCredentials 

    See https://github.com/golang/oauth2/blob/a835fc4358f6852f50c4c5c33fddcd1adade5b0a/jwt/jwt.go#L123C8-L123C8 for reference
    @msdrigg
    msdrigg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    8576b2a View commit details
    Browse the repository at this point in the history

  6. Internal improvements 

    - Sort scope vec before using it as a hashmap key. Vecs of scopes aren't dependent on order, so the hashmap key shouldn't be either
- Reduce complexity by moving all calls to `token::from_string` to `token::new`
    @msdrigg
    msdrigg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    cd90392 View commit details
    Browse the repository at this point in the history

  7. Fixing clippy warnings

    @msdrigg
    msdrigg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    15a9d62 View commit details
    Browse the repository at this point in the history