Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fix for token store in .doctrees #75

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Adding fix for token store in .doctrees #75

merged 2 commits into from
Apr 28, 2023

Conversation

djpugh
Copy link
Owner

@djpugh djpugh commented Apr 28, 2023

Session GITHUB_TOKEN was stored in this file - not a security risk, but better to stop committing them

@djpugh djpugh marked this pull request as ready for review April 28, 2023 18:04
@djpugh djpugh enabled auto-merge (squash) April 28, 2023 18:04
@github-actions github-actions bot added the fix label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #75 (2deaec1) into main (e06e02c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files           6        6           
  Lines         141      141           
=======================================
  Hits          139      139           
  Misses          2        2           
Flag Coverage Δ
tests 98.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@djpugh djpugh merged commit db67dc7 into main Apr 28, 2023
@djpugh djpugh deleted the fix/doctree-commit branch April 28, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant