Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid type flags in the OS/2 and Windows table #87

Closed
IvanUkhov opened this issue Dec 19, 2022 · 0 comments · Fixed by #85
Closed

Invalid type flags in the OS/2 and Windows table #87

IvanUkhov opened this issue Dec 19, 2022 · 0 comments · Fixed by #85
Assignees
Labels

Comments

@IvanUkhov
Copy link

The fsType field in the OS/2 and Windows table is incorrectly set to one. It is supposed to be zero.

Please see google/fonts#5724 for more details.

@justvanrossum justvanrossum self-assigned this Dec 19, 2022
justvanrossum added a commit to martelahaie/Bungee that referenced this issue Aug 3, 2023
justvanrossum added a commit that referenced this issue Sep 18, 2023
* New script to break out the layers into final UFO sources

New script to break out the layers into final UFO sources.

* Ignore 'build' folder

* fiddle with file and folder names; set familyName and styleName

* BungeeLayers-Shade should not add tracking

* Add initial build script

* Print what's happening

* whitespace

* copy kerning, groups and features; reroute feature includes to the right place

* fiddle with name and value of tracking offset: make it independent of the tracking value itself

* don't convert to production glyph names

* Add script to build the layered + rotated UFO sources

* Add rotation script and its output to fontmake input

* removed unused function

* finish exception mapping; map to None if this glyph will be mapped to, but also exists 'normally'

* Assemble Tools

Assemble tools for assembleSources.py and assembleRotatedSources.py

* remove venv map

* ignore all the things

* Layer-Shade does not need full decomposition

* create script for COLv0 fonts

* Add color sources to build

* minor cleanup

* fix color name

* rename var

* some shuffling of lines

* More shuffling/renaming

* Add gradients and build source for Bungee Spice

* Add Regular to Bungee Basic

* attempt to make tracking logic match the existing fonts

* formatting

* Also look into (nested) components for shade layers

* special-case /space: it should be tracked for Basic Shade

* special-case a whole bunch of glyph names for shade tracking/offsetting

* Add comment about these exceptions

* update color palettes bungee-spice

* Add initial requirements file

* Update requirements

* Clear OS/2 fsType flags, this fixes #87

---------

Co-authored-by: marte verhaegen <marte.verhaegen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants