-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect that Stamen tiles are now hosted by Stadia Maps #350
Comments
Quick bump on this for the project maintainers. We are still planning to start brownouts toward the end of September to let people know to switch over. It would be great to get ggmap updated ASAP since I assume many users and platforms have a longer update cycle. |
Indeed. We're using Shiny for https://parkingreform.org/mandates-map/ and are worried we won't be able to fix this in time. We've been migrating from Shiny to using Leaflet directly, which will avoid the problem. But we'd be in trouble if we hadn't already started the migration before this change to Stamen was announced. |
As a note to anyone finding this via a Google search wondering why their maps include warning tiles from Stamen, we have started serving brownout tiles infrequently in order to let developers know they have less than a month to upgrade. Hopefully the open PR can get merged soon. |
Hello @ferrancarril. I think this is probably related, but I unfortunately don't know the internals of the ggmap library that well. We just updated our guide a few hours ago with details on how to install our patched version until the PR is merged. Let me know if you have any questions! https://docs.stadiamaps.com/guides/migrating-from-stamen-map-tiles/#ggmap |
I can confirm that @ferrancarril is related to the brownout of stamen_map and I have successfully been able to get it working using similar steps to what you provided above The same problem is shown in #353 |
See http://maps.stamen.com/stadia-partnership/ and https://docs.stadiamaps.com/guides/migrating-from-stamen-map-tiles/.
This will probably be a semver breaking change regardless of any reorganization (since an API key will be required in the future). Additionally, the approach taken by Leaflet Providers, OpenLayers, etc. has been to change the source name while we're making breaking changes anyways.
I'll try to work up a PR myself and let you know if I get stuck; my R is a bit rusty ;)
The text was updated successfully, but these errors were encountered: