Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dkavolis! A user posted a log on the forum, and I noticed this while investigating:
https://forum.kerbalspaceprogram.com/index.php?/topic/206468-having-unexpected-mark-stack-overflow-and-other-unexpected-crashes-in-a-modded-install/
Also submitted Boris-Barboris/AtmosphereAutopilot#29 for the same problem in another mod.
Problem
If a user on Windows puts a
"
character in a vessel's name, this is seen in the log:This causes the serialization to fail, which may be cascading into other problems as well:
Cause
Windows doesn't allow certain characters in filenames, including
"
, and FARc is trying to put user input into a filename without sanitizing it.Changes
Now this filename is passed through
KSPUtil.SanitizeFilename
before use (the same thing the stock game does with.craft
files), so it will not contain illegal characters.