Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airplane Plus Compatibility #115

Merged
merged 3 commits into from
Jun 6, 2021
Merged

Airplane Plus Compatibility #115

merged 3 commits into from
Jun 6, 2021

Conversation

Alioth81
Copy link

- added Airplane Plus compatibility Patch (ignores rotors/props from voxelation and adds FAR configs for aero parts)
- needed to add a small change so that the ignored mesh list is not overwritten
- added a small change to fix a potential division by 0 that theoretically could happen (related to my previous pull request)
@Alioth81
Copy link
Author

Alioth81 commented May 23, 2021

Small video showing a 5 part example helicopter and an airliner with some Airplane Plus parts
https://youtu.be/AXPjcaaZBB4
some limitations:

  • double fowler flaps are not possible with FAR as it only accepts one control surface module (therefore both surfaces are combined into a single flap)
  • no other changes to the Airplane Plus parts (some wheels and the KT6C "Kitty" Turboshaft Engine seem glitchy but they are even without FAR, the power curves of the props seem a bit weird and overpowered. In addition many of the CoMs of the prop engines seem quite a bit off). However those changes are probably better done in the Airplane Plus mod itself.

- changed visibility of dynamic deflection controls to be hidden at start (to match behaviour of the std control surfaces control)
@dkavolis
Copy link
Owner

dkavolis commented Jun 5, 2021

Thanks for the PR. Code changes look fine but the mod patch should be included with the mod itself rather than FAR.

@Alioth81
Copy link
Author

Alioth81 commented Jun 5, 2021

I will open a pull request on Airplane Plus for the patch

- removed AirplanePlus Compatibility Patch as it should be patched in the Airplane Plus mod
@dkavolis
Copy link
Owner

dkavolis commented Jun 6, 2021

Thanks

@dkavolis dkavolis merged commit e225533 into dkavolis:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants