Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various NREs. Calculate vessel orientation without using the NavBall, which doesn't exist in IVA mode. #133

Merged
merged 8 commits into from
May 3, 2022
Merged

Fix various NREs. Calculate vessel orientation without using the NavBall, which doesn't exist in IVA mode. #133

merged 8 commits into from
May 3, 2022

Commits on May 2, 2022

  1. Fix various NREs. Calculate vessel orientation without using the NavB… 

    …all (which doesn't exist in IVA mode).
    @BrettRyland
    BrettRyland committed May 2, 2022
    Configuration menu
    Copy the full SHA
    8339147 View commit details
    Browse the repository at this point in the history

  2. Use the more elegant 'cap?.' instead of 'if (cap != null)'.

    @BrettRyland
    BrettRyland committed May 2, 2022
    Configuration menu
    Copy the full SHA
    b47026d View commit details
    Browse the repository at this point in the history

  3. Fix KeyNotFoundException in FARAeroSection.UpdateAeroSection using Tr… 

    …yGetValue.
    @BrettRyland
    BrettRyland committed May 2, 2022
    Configuration menu
    Copy the full SHA
    df35aa7 View commit details
    Browse the repository at this point in the history

  4. Initialise _vehicleCrossSection as an empty array to avoid an NRE.

    @BrettRyland
    BrettRyland committed May 2, 2022
    Configuration menu
    Copy the full SHA
    a5619dc View commit details
    Browse the repository at this point in the history

  5. Update the ship parts list before iterating through it (avoids null p… 

    …arts).
    @BrettRyland
    BrettRyland committed May 2, 2022
    Configuration menu
    Copy the full SHA
    2474742 View commit details
    Browse the repository at this point in the history

  6. Remove the now unneeded 'p == null' check.

    @BrettRyland
    BrettRyland committed May 2, 2022
    Configuration menu
    Copy the full SHA
    5fc2b1d View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Call UpdateShipPartsList before invoking OnVesselPartsChange and befo… 

    …re the initial CalculateSurfaceFunctions.
    @BrettRyland
    BrettRyland committed May 3, 2022
    Configuration menu
    Copy the full SHA
    e45e3b4 View commit details
    Browse the repository at this point in the history

  2. Use backward finite difference for the 'back' index of the first deri… 

    …vative calculation in CalculateSonicPressure.
    @BrettRyland
    BrettRyland committed May 3, 2022
    Configuration menu
    Copy the full SHA
    0c923d5 View commit details
    Browse the repository at this point in the history