Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE in debug voxels for real now #59

Merged
merged 2 commits into from
May 12, 2019
Merged

Fix NRE in debug voxels for real now #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68a3873
Fix NRE in debug voxels for real now
dkavolis May 12, 2019
3a69a14
Update README.md
dkavolis May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion FerramAerospaceResearch/FARPartGeometry/DebugVisualVoxelMeshController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ private void UpdateActive()
{
foreach (DebugVisualVoxelSubmesh submesh in m_submeshes)
{
if ((object)submesh != null) submesh.active = m_active;
if (submesh != null)
submesh.active = m_active;
}
}

Expand Down
3 changes: 1 addition & 2 deletions FerramAerospaceResearch/FARPartGeometry/DebugVisualVoxelSubmesh.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ public bool active
get => gameObject.activeSelf;
set
{
if (gameObject != null)
gameObject.SetActive(value);
gameObject.SetActive(value);
}
}

Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ CHANGELOG
=======================================================
-----------------------master branch---------------------

Now really fixed ocassional NRE when cleaning up debug voxels ([#59](https://github.com/dkavolis/Ferram-Aerospace-Research/pull/59))
Fix unsubsribing correct method from `GameEvents.onGUIEngineersReportDestroy` in `EditorGUI` ([#58](https://github.com/dkavolis/Ferram-Aerospace-Research/pull/58))
Fix assymetrical voxelization on some Mk2/Mk3 adapters [#56](https://github.com/dkavolis/Ferram-Aerospace-Research/pull/56) ([#57](https://github.com/dkavolis/Ferram-Aerospace-Research/pull/57))
Cache some Unity properties for performance reasons ([#53](https://github.com/dkavolis/Ferram-Aerospace-Research/pull/53))
Expand Down