Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeElement no effect #8

Closed
muziling opened this issue Oct 4, 2015 · 1 comment
Closed

removeElement no effect #8

muziling opened this issue Oct 4, 2015 · 1 comment

Comments

@muziling
Copy link

muziling commented Oct 4, 2015

https://github.com/dkharrat/NexusDialog/blob/88978bdb58f81230d2c3778509b09fcce2bfce69/nexusdialog/src/main/java/com/github/dkharrat/nexusdialog/controllers/FormSectionController.java

public FormElementController removeElement(FormElementController element) {
return elements.remove(element.getName());
}

maybe need to add orderedElements.remove(element);

or just change to
public FormElementController removeElement(FormElementController element) {
return removeElement(element.getName());
}

@dkharrat
Copy link
Owner

dkharrat commented Oct 4, 2015

Good catch! You're right, this is a bug. Should be:

public FormElementController removeElement(FormElementController element) {
    return removeElement(element.getName());
}

I'll fix this in the next release.

flibbertigibbet added a commit to flibbertigibbet/NexusDialog that referenced this issue Feb 4, 2016
…le-image-controller

Make it easy to subclass ImageController.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants