-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directive does not work when Build for production #7
Comments
Hi, i think problem in the Configuration, when you deploy you microfront MfeModule try to find it in http://localhost:5005/remoteEntry.js Try to provide correct host path where you deploy your MFE. Check this article, this should help you. |
Hi dkrunov and thanks for your reply Note: yes, I am using the approach in the article. So in this case is still local but built as production. So the path is the same. The difference is code is optimized by webpack.
ngx-mfe code
|
Hi @hmendesm! |
Thanks Dkhrunov
In meantime, I downloaded you code and made modifications to get the
componentType. I created a new decorator.
I am testing right now. The issue when the code is built with optimizing,
the names of class and variables are gone. So you need a way to keep the
name and componettype together. The new decorator will do that. I use Map
and the key is the name of the class and the value the componenttype. So I
am adding the decorator to all my components that I will use *mfeOutler.
Thanks for all your work on this
Best
Hmendezm
…On Thu, Jun 23, 2022 at 3:42 PM Denis Khrunov ***@***.***> wrote:
Hi @hmendesm!
Thanks for your bug report, I have found the source of this problem, I
will update the library soon and post a new version where I will make
corrections.
When I do this, I will contact you.
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOLKVYSWNJ6NFQV4432FX3VQS4YVANCNFSM5ZQM7VLQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Cool, I want to see it in action, can you create a Pull Request with your changes? |
In meantime, I`m has anouther solution, but for this you will have to exposes the component class itself, as it was before version 1.1.0, like you do it with modules. You can check how it work before v1.1.0 source code here |
Hello! But with v2 I made few breaking changes, check updated documentation here and check out a Migration guide to v2 |
Thanks! I will test it next week and let you know. I forget to create pr
with la solution I implemented. Maybe it is not needed any more.
…On Thu, Jul 7, 2022 at 4:32 PM Denis Khrunov ***@***.***> wrote:
Hello!
I introduce a new version 2.0.0, where I fixed this issue.
But with v2 I made few breaking changes, check updated documentation here
<https://github.com/dkhrunov/ngx-mfe/blob/master/README.md> and check out
a Migration guide to v2
<https://github.com/dkhrunov/ngx-mfe/blob/master/migration-guide-to-v2.md>
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOLKV2KLSO6TEVKPOLJQGLVS45HBANCNFSM5ZQM7VLQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
HI dkhrunov,
Sorry for bothering you. Now I am working on deploying the app in production mode. In this case, I have all remotes working standard alone. The problem is when I use the directive I got the error below. My guess is that when the directive tries to upload the component, this is not found. Note: The app works if I run serve (development mode)
do you have any idea what is the problem?
I have the following in place:
HTML
Configuration
Sharedcompoenent MFE
webpack.config
Loader.module
ERROR
The text was updated successfully, but these errors were encountered: