Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature Add support for reordering for belongs_to resources #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delphist
Copy link

#3

@yjukaku
Copy link

yjukaku commented Jan 17, 2018

I would love to see this merged. However, I think this might be the better way to go?

reorder_url, query_params = active_admin_resource_for(resource.class).route_instance_path(resource).split '?', 2
reorder_url += "/reorder"
reorder_url += "?" + query_params if query_params
span(reorder_handle_content, :class => 'reorder-handle', 'data-reorder-url' => reorder_url)

@delphist
Copy link
Author

@yjukaku need to check it, maybe yes – hard to remember where i'm used it to reproduce the bug. Give me some time, please

@dkniffin
Copy link
Owner

@delphist Any update on whether @yjukaku's suggestion works? Also, would you mind fixing the conflict with master?

@dkniffin
Copy link
Owner

@delphist is this still valid? If so, can you please rebase to get the new test suite and fix the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants