Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency on attrs #293

Closed
DavidHuebner opened this issue Nov 9, 2023 · 0 comments · Fixed by #294
Closed

Relax dependency on attrs #293

DavidHuebner opened this issue Nov 9, 2023 · 0 comments · Fixed by #294
Assignees
Milestone

Comments

@DavidHuebner
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The setup.py currently requires the attrs package in version 21.2.*. This is outdated and we ran into conflicting versions e.g. with jsonschema that requires attrs>=22.2.0. jsonschema is e.g. required for jupyterlab, so some users have problems when they install the libraries sequentially and cannot currently use the newest version of jupyterlab.

Describe the solution you'd like
We should relax the dependency on attrs. In the 22.x and 23.x release the support for Python 3.5 and 3.6 was dropped, respectively. But this is not a blocker as cassis already requires Python>=3.7. To be on the save side, we can change the version to "attrs>=21.2,<24". I think that no changes in the code are required.

Describe alternatives you've considered
Not constraining the maximal attrs version may be problematic as attrs may not support Python 3.7 from version 24.x onwards.

Additional context
If you first run pip install jupyterlab and then pip install dkpro-cassis, pip will complain.

DavidHuebner added a commit to DavidHuebner/dkpro-cassis that referenced this issue Nov 9, 2023
@DavidHuebner DavidHuebner self-assigned this Nov 15, 2023
@DavidHuebner DavidHuebner added this to the 0.9.0 milestone Nov 15, 2023
@DavidHuebner DavidHuebner linked a pull request Nov 15, 2023 that will close this issue
DavidHuebner added a commit that referenced this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant