#174 - FSes that are only transitively referenced cannot be serialized (#179) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
reckart
commented
Aug 18, 2021
reckart
commented
- Initial fix did only work for the first fs without xmiID, but as soon as there would be two FSes with missing ids, it broke
- Extended the test
- Implemented an alternative fix that optionally sets the missing IDs while scanning the CAS for FSes thus also avoiding scanning the CAS twice during serialization
#179) - Initial fix did only work for the first fs without xmiID, but as soon as there would be two FSes with missing ids, it broke - Extended the test - Implemented an alternative fix that optionally sets the missing IDs while scanning the CAS for FSes thus also avoiding scanning the CAS twice during serialization
#179) - Only generate new ID if ID is actually missing
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 97.37% 97.39% +0.02%
==========================================
Files 9 9
Lines 1940 1955 +15
==========================================
+ Hits 1889 1904 +15
Misses 51 51
Continue to review full report at Codecov.
|
#179) - Turn on ID generation during FS scan in general because the FS scan internally uses a map in which the ID is the key and if the IDs are not uniquely generated, then the result of the method is incomplete. - Add consistency checks fo _find_all_fs to detect e.g. duplicate FS IDs - Fixed a test which introduced a duplicate FS ID
#179) - Added test to fail on duplicate IDs
reckart
deleted the
bugfix/174-FSes-that-are-only-transitively-referenced-cannot-be-serialized
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.