Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#234 - cas_to_comparable_text fails with null arrays #235

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Oct 1, 2021

  • Fixed issue
  • Added test case

@reckart reckart added the 🐛Bug label Oct 1, 2021
@reckart reckart added this to the 0.6.2 milestone Oct 1, 2021
@reckart reckart self-assigned this Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #235 (39fe252) into main (5f5bb56) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   95.85%   96.14%   +0.29%     
==========================================
  Files           4        4              
  Lines        1400     1402       +2     
==========================================
+ Hits         1342     1348       +6     
+ Misses         58       54       -4     
Impacted Files Coverage Δ
cassis/util.py 98.03% <100.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5bb56...39fe252. Read the comment docs.

@reckart reckart merged commit ee4dbfc into main Oct 1, 2021
@reckart reckart deleted the bugfix/234-cas_to_comparable_text-fails-with-null-arrays branch October 1, 2021 10:29
@reckart reckart modified the milestones: 0.6.2, 0.7.0 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant