#253 - Do not emit warnings during merge #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now do not warn when redefining features during merge, as that leads too many warnings, especially when merging very similar type systems.
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 95.43% 95.49% +0.05%
==========================================
Files 5 5
Lines 1861 1863 +2
==========================================
+ Hits 1776 1779 +3
+ Misses 85 84 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
reckart
approved these changes
Mar 25, 2022
|
We auto generate eq based on features when magically generating the class on the fly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now do not warn when redefining features during merge, as that leads too many warnings, especially when merging very similar type systems.