#290 - Speedup load_cas_from_xmi by improving offset mapping #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 95.12% 95.11% -0.01%
==========================================
Files 5 5
Lines 1968 1966 -2
==========================================
- Hits 1872 1870 -2
Misses 96 96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…o#290-Speedup_load_cas_from_xmi_by_improving_offset_mapping: 1.Added an LRU Cache is used for speeding up the `encode` function and refactored the `create_offset_mapping` 2. When reading a CAS-XMI, directly pass down the offset mappings to avoid recomputing them.
reckart
approved these changes
Sep 20, 2023
|
Thanks for the PR :) |
reckart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodefunction and refactored thecreate_offset_mappingReduced the time spent in
create_offset_mappingfrom 49% to 8%.