Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated keyword body with do and avoid DIP-1000 scope errors #2164

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

nordlow
Copy link
Contributor

@nordlow nordlow commented Aug 24, 2021

No description provided.

@nordlow
Copy link
Contributor Author

nordlow commented Aug 24, 2021

Getting scope errors in CI jobs. What to do?

thewilsonator added a commit to thewilsonator/undeaD that referenced this pull request Aug 24, 2021
…pe parameter `o` calling dub.internal.undead.xml.toType!(const(Item)).toType"

blocking dlang/dub#2164
@thewilsonator
Copy link
Contributor

dlang/undeaD#47

@Geod24
Copy link
Member

Geod24 commented Aug 25, 2021

source/dub/internal/undead/xml.d

The problematic code is in dub, so you need to apply the diff here as well.

@RazvanN7
Copy link
Contributor

The problematic code is in dub, so you need to apply the diff here as well.

@nordlow This.

@nordlow
Copy link
Contributor Author

nordlow commented Aug 25, 2021

I don't follow. I can't find any more references to the body keyword in D files in my local checkout of this branch.

@RazvanN7
Copy link
Contributor

The patch that @thewilsonator applied to undead needs to be applied to the local copy of undead in dub. See source/dub/internal/undead/xml.d : it's the same code as in dlang/undeaD#47

@nordlow
Copy link
Contributor Author

nordlow commented Aug 25, 2021

The patch that @thewilsonator applied to undead needs to be applied to the local copy of undead in dub. See source/dub/internal/undead/xml.d : it's the same code as in dlang/undeaD#47

Ahh, sorry. I was searching for the body keyword. I'll fix.

@nordlow
Copy link
Contributor Author

nordlow commented Aug 25, 2021

Changes to xml.d applied.

… parameter `o` calling dub.internal.undead.xml.toType!(const(Item)).toType" blocking dlang#2164

Also see dlang/undeaD#47.
@WebFreak001
Copy link
Member

it says the toType function in xml.d is missing scope on its argument, not sure how it works upstream? (should probably even be scope return)

@nordlow
Copy link
Contributor Author

nordlow commented Aug 25, 2021

it says the toType function in xml.d is missing scope on its argument, not sure how it works upstream? (should probably even be scope return)

Done.

@nordlow
Copy link
Contributor Author

nordlow commented Aug 25, 2021

Ready now.

@dlang-bot dlang-bot merged commit e464804 into dlang:master Aug 25, 2021
@nordlow nordlow changed the title Replace deprecated keyword body with do Replace deprecated keyword body with do and avoid DIP-1000 scope errors Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants