add the build ID in TargetDescription #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 14 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5280256 bin/dub
-rough build time=77s
+rough build time=76sFull build output |
|
Instead of Even with the build Id available, if this structure changes, Meson will be lost again. |
|
A full path would be better, as Meson shouldn't depend on implementation details of Dub. As @Geod24 mentioned, |
|
There seem to be a bug in "versions": [
"EventcoreEpollDriver",
"Have_taggedalgebraic"
],However when I run It means that This come down to this piece of code, which looks wrong to me. I don't understand why dependencies need versions from their parents. // 1. downwards inherits versions, debugVersions, and inheritable build settings
static void configureDependencies(const scope ref TargetInfo ti, TargetInfo[string] targets, size_t level = 0)
{
// do not use `visited` here as dependencies must inherit
// configurations from *all* of their parents
logDebug("%sConfigure dependencies of %s, deps:%(%s, %)", ' '.repeat(2 * level), ti.pack.name, ti.dependencies);
foreach (depname; ti.dependencies)
{
auto pti = &targets[depname];
mergeFromDependent(ti.buildSettings, pti.buildSettings);
configureDependencies(*pti, targets, level + 1);
}
}
configureDependencies(*roottarget, targets); |
actually I think having both would be beneficial, as dub describe will only tell you about a single configuration, but you might want to know what everything in the folder is. |
|
When I completely remove the "downwards inherits versions etc." section from Dub's code, I still make valid builds. Right now |
It is used quite heavily, see bindbc projects that use it to specify the version of the library it needs to load. Very useful. |
Ah yes, quite obvious. |
rtbo
force-pushed
the
buildid_in_describe
branch
from
d226782 to
5c3268f
Compare
Allow 3rd party programs (e.g. Meson) to locate artifacts in the cache
rtbo
force-pushed
the
buildid_in_describe
branch
from
5c3268f to
bbf33c0
Compare
|
Hi, can this be merged before next Dub release? |
WebFreak001
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow 3rd party programs (e.g. Meson) to locate artifacts in the cache.
Following @Geod24 comment in #2642.
@WebFreak001 @Geod24 This would be enough for Meson to locate Dub's artifacts.
If you prefer to use this proposal, feel free to revert #2642.