Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 10386: Make std.math.isIdentical work in CTFE with coverage tests #10576

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

runiixx
Copy link
Contributor

@runiixx runiixx commented Dec 7, 2024

I took the modifications @n8sh made in math.d and moved in traits.d since math.d doesn't exist anymore and the math library is now composed of multiple files, and then added more tests because the piece of code that is interpreted in CTFE wasn't covered.
Credit to @n8sh for the code in isIdentical.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 7, 2024

Thanks for your pull request and interest in making D better, @runiixx! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10576"

@LightBender LightBender changed the title Make std.math.isIdentical work in CTFE with coverage tests Fix Issue 10386: Make std.math.isIdentical work in CTFE with coverage tests Dec 7, 2024
@LightBender
Copy link
Contributor

We are no longer using or linking to Bugzilla for Phobos. I have updated the PR title, but can you please update the commit message to reference the corresponding GH Issue here: #10386

Signed-off-by: runiixx <murgua03@gmail.com>
Signed-off-by: runiixx <murgua03@gmail.com>
@LightBender LightBender merged commit b2ecb21 into dlang:master Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants