Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10581 – std.logger has an ostensibly broken example and wrong docs #10582

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

0xEAB
Copy link
Member

@0xEAB 0xEAB commented Dec 10, 2024

Fixes #10581.
Revamp of #10573.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @0xEAB! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10582"

@0xEAB
Copy link
Member Author

0xEAB commented Dec 10, 2024

Your PR doesn't reference any Bugzilla issue.

No longer matters, does it?

@thewilsonator
Copy link
Contributor

Correct

…rong docs

Co-authored-by: Elias Batek <desisma@heidel.beer>
@0xEAB 0xEAB force-pushed the std-logger-example branch from a2b3ee3 to b3aee4d Compare December 11, 2024 01:19
@dlang-bot dlang-bot merged commit 8973596 into dlang:master Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std.logger has an ostensibly broken example and wrong docs
5 participants