Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move Cirrus jobs to GitHub Actions #8831

Merged
merged 2 commits into from
Oct 28, 2023
Merged

CI: Move Cirrus jobs to GitHub Actions #8831

merged 2 commits into from
Oct 28, 2023

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Oct 28, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8831"

@kinke kinke force-pushed the ci_gha branch 2 times, most recently from 3408539 to 90f7c3b Compare October 28, 2023 17:50
@kinke
Copy link
Contributor Author

kinke commented Oct 28, 2023

diff:
----
 fail_compilation/test22361.d(11): Error: unable to read module `this_module_does_not_exist`
 fail_compilation/test22361.d(11):        Expected 'this_module_does_not_exist.d' or 'this_module_does_not_exist/package.d' in one of the following import paths:
 import path[0] = fail_compilation
-import path[1] = $p:druntime/import$
-import path[2] = $p:phobos$
+import path[1] = /Users/runner/work/phobos/dmd/compiler/test/../../druntime/import
+import path[2] = /Users/runner/work/phobos/dmd/compiler/test/../../../phobos

$p: seems buggy; it's using findSplitAfter, so for $p:phobos and the intermediate phobos dir here (phobos is cloned into /Users/runner/work/phobos/phobos by default), it seems to eagerly consume the first /Users/runner/work/phobos and choke on the remainder (dmd/compiler/test/../../../phobos). Sigh...

@kinke kinke force-pushed the ci_gha branch 2 times, most recently from be6b504 to ee218ad Compare October 28, 2023 18:42
/Users/runner/work/phobos/phobos => /Users/runner/work/phobos
@kinke kinke marked this pull request as ready for review October 28, 2023 19:30
@kinke kinke requested a review from ibuclaw October 28, 2023 19:30
@ibuclaw
Copy link
Member

ibuclaw commented Oct 28, 2023

diff:
----
 fail_compilation/test22361.d(11): Error: unable to read module `this_module_does_not_exist`
 fail_compilation/test22361.d(11):        Expected 'this_module_does_not_exist.d' or 'this_module_does_not_exist/package.d' in one of the following import paths:
 import path[0] = fail_compilation
-import path[1] = $p:druntime/import$
-import path[2] = $p:phobos$
+import path[1] = /Users/runner/work/phobos/dmd/compiler/test/../../druntime/import
+import path[2] = /Users/runner/work/phobos/dmd/compiler/test/../../../phobos

$p: seems buggy; it's using findSplitAfter, so for $p:phobos and the intermediate phobos dir here (phobos is cloned into /Users/runner/work/phobos/phobos by default), it seems to eagerly consume the first /Users/runner/work/phobos and choke on the remainder (dmd/compiler/test/../../../phobos). Sigh...

Bleh... Ok to merge now?

@kinke
Copy link
Contributor Author

kinke commented Oct 28, 2023

Ok to merge now?

Yep, worked around it in the 2nd commit.

@ibuclaw ibuclaw merged commit 3e76526 into dlang:master Oct 28, 2023
11 checks passed
@kinke kinke deleted the ci_gha branch October 28, 2023 23:04
kinke added a commit to kinke/dmd that referenced this pull request Oct 29, 2023
So that e.g. `$:phobos$` for an actual path of `/phobos/phobos`
matches the whole path instead of eagerly stopping at `/phobos`.
See dlang/phobos#8831 (comment).
kinke added a commit to kinke/dmd that referenced this pull request Oct 29, 2023
So that e.g. `$p:phobos$` for an actual path of `/phobos/phobos`
matches the whole path instead of eagerly stopping at `/phobos`.
See dlang/phobos#8831 (comment).
kinke added a commit to kinke/dmd that referenced this pull request Oct 29, 2023
So that e.g. `$p:phobos$` for an actual path of `/phobos/phobos`
matches the whole path instead of eagerly stopping at `/phobos`.
See dlang/phobos#8831 (comment).
RazvanN7 pushed a commit to dlang/dmd that referenced this pull request Oct 30, 2023
So that e.g. `$p:phobos$` for an actual path of `/phobos/phobos`
matches the whole path instead of eagerly stopping at `/phobos`.
See dlang/phobos#8831 (comment).
kinke added a commit to ldc-developers/ldc that referenced this pull request Nov 4, 2023
…15745)

So that e.g. `$p:phobos$` for an actual path of `/phobos/phobos`
matches the whole path instead of eagerly stopping at `/phobos`.
See dlang/phobos#8831 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants