-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 24215 - isBasicType!Enum should be false #8838
Conversation
Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8838" |
Dub build failure is caused by this change somehow; time to investigate... |
Dependant PR merged. |
Considering it broke a project on buildkite, it probably warrants a change log entry |
Hang on a minute! The way std.traits classifies types doesn't always line up with the language specification and nothing says it has to. For example as far as the D language is concerned char and bool are unsigned integer types but std.traits.isUnsigned and std.traits.isIntegral present a view of the world that draws a distinction between characters, boolean values, and numbers. Breaking changes to std.traits are particularly bad given how foundational it is. Even D programmers who use little else of Phobos rely on it. Is there some common coding pattern using isBasicType that runs into problems if the programmer doesn't explicitly consider enums and exclude them? That would be a decent reason to consider changing it. |
I wanted this version of If consensus is that this is too risky, I'm fine with reverting it. We can revisit for Phobos v2, if and when that ever happens. @atilaneves, thoughts? |
If there are issues and you have a workaround, I say it's better/easier to revert. |
No description provided.