Fix Issue 16593 - Building "tools" produces deprecation warnings #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wilzbach
approved these changes
Oct 4, 2016
| @@ -15,15 +15,15 @@ void usage() | |||
|
|
|||
| int main(string[] args) | |||
| { | |||
| if (args.length == 1) return usage(), 1; | |||
There was a problem hiding this comment.
Holy cow a comma operator in the wild, and it's in our repo. 😆
There was a problem hiding this comment.
I had a few in ae:
CyberShadow/ae@d8ef8eb
CyberShadow/ae@99585d4
CyberShadow/ae@1674d2b
There was a problem hiding this comment.
I'd never doubt you would push the language to your advantage. :)
|
What's up with Travis lately? Is master broken or is it something else? |
wilzbach
force-pushed
the
pull-20161004-212702
branch
from
bdcf028
to
6a25720
Compare
Yep with 2.072 we had some issues, luckily they have been fixed with #202. @CyberShadow I just rebased your PR to the upstream/master, s.t. Travis passes & we can move forward (I like the new GitHub feature). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=16593