Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add guard for MagickImage.Morphology #1618

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix: add guard for MagickImage.Morphology #1618

merged 2 commits into from
Apr 30, 2024

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Apr 29, 2024

Description

👋

I had to take a look at ImageMagick source code to understand why MagickImage.Morphology's iterations parameter can be negative.

So this PR add both a guard and update documentation for the parameter.

Regards.

dlemstra
dlemstra approved these changes Apr 30, 2024
View reviewed changes
Copy link
Owner

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another improvement of this library!

@dlemstra dlemstra merged commit d58472f into dlemstra:main Apr 30, 2024
26 checks passed
@Gounlaf Gounlaf deleted the guard-magickimage-morphology branch April 30, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlemstra dlemstra dlemstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gounlaf @dlemstra