Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drawable-interline-spacing #104

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

hannanilsson
Copy link
Contributor

Hi again! August came early this year 😅

We wanted to add the possibility to use interline-spacing, however, negative values does not seem to work. We are unable to understand why. Could you maybe have a look? Thank you!

@dlemstra
Copy link
Owner

dlemstra commented Jul 6, 2023

Thanks for coming back so quickly to help me with this project. Would you be willing to change this PR and remove the negative value unit test? I can then merge this and investigate why the negative value is not working. It seems to be working on the command line so it should work in wasm.

@hannanilsson
Copy link
Contributor Author

Absolutely, I have removed it now! We just wanted to add it initially to demonstrate the issue. It sounds promising that it should work with negative values, hope your investigation can find why it doesn't! 😄

@dlemstra dlemstra merged commit d9c5541 into dlemstra:main Jul 7, 2023
@dlemstra
Copy link
Owner

dlemstra commented Jul 9, 2023

Thanks for adding the test for a negative value earlier. I have found what was causing it not to work and fixed the issue in ImageMagick. This will be fixed when I upgrade Magick.Native later this week. And then I will also add a unit test for a negative value.

@hannanilsson
Copy link
Contributor Author

Glad to hear that! Thank you for your work! ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants