Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package type module #131

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Make package type module #131

merged 4 commits into from
Dec 18, 2023

Conversation

Peeterush
Copy link
Contributor

The commit Make package type module sets the package.json to type: "module", and makes the required changes throughout the codebase. This means all files now use ESM by default, and files using CJS have to be explicitly marked as such.

The commit Restore test environment reuse does just that, making npm run test run about 4 times as fast again.

The other two commits just fix some inconsistencies: a few files used double quotes and not all internal node modules imports were marked as such.

@dlemstra
Copy link
Owner

Thanks for your help. Normally I would want to have this in separate pull requests but thanks for splitting this up in separate commits. Could you amend the "Make package type module" commit and include that "Fix deno import" commit so we have a nice clean history?

@Peeterush
Copy link
Contributor Author

Like this?

@dlemstra
Copy link
Owner

Yup, thanks!

@dlemstra dlemstra merged commit 0bc805a into dlemstra:main Dec 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants